New Template - cisco_ios_show_object-group #850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkomissarov
requested review from
FragmentedPacket,
itdependsnetworks,
jmcgill298 and
jvanderaa
as code owners
|
Hello, |
|
@pkomissarov Sorry about the huge delay with reviewing. I will try and get it review within the next day. We appreciate your patience. |
FragmentedPacket
suggested changes
Feb 22, 2021
|
@pkomissarov Just wanted to see if you could address the open conversations here and then we can get this merged in. |
This was referenced Mar 14, 2021
Closed
jvanderaa
pushed a commit
that referenced
this pull request
Nov 10, 2021
guillaume-mbali
pushed a commit
to unyc-io/ntc-templates
that referenced
this pull request
Apr 12, 2023
cppmonkey
pushed a commit
to cppmonkey/ntc-templates
that referenced
this pull request
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE TYPE
COMPONENT
cisco_ios_show_object-group
SUMMARY
#850
As @FragmentedPacket proposed, I applied changes:
Renamed OGR_NAME to NAME
Renamed OGR_TYPE to TYPE
Renamed NESTED_OGR to NESTED_GROUPS
Changed last line to